rtc: pl031: fix rtc features null pointer dereference
authorAli Pouladi <quic_apouladi@quicinc.com>
Fri, 25 Feb 2022 16:19:24 +0000 (08:19 -0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 23 Mar 2022 18:58:37 +0000 (19:58 +0100)
commitea6af39f3da50c86367a71eb3cc674ade3ed244c
tree9fa61c0b42103efbe1f70424b0595417ce09ba93
parent811f5559270f25c34c338d6eaa2ece2544c3d3bd
rtc: pl031: fix rtc features null pointer dereference

When there is no interrupt line, rtc alarm feature is disabled.

The clearing of the alarm feature bit was being done prior to allocations
of ldata->rtc device, resulting in a null pointer dereference.

Clear RTC_FEATURE_ALARM after the rtc device is allocated.

Fixes: d9b0dd54a194 ("rtc: pl031: use RTC_FEATURE_ALARM")
Cc: stable@vger.kernel.org
Signed-off-by: Ali Pouladi <quic_apouladi@quicinc.com>
Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220225161924.274141-1-quic_eberman@quicinc.com
drivers/rtc/rtc-pl031.c