proc/sysctl: don't return ENOMEM on lookup when a table is unregistering
authorIvan Delalande <colona@arista.com>
Thu, 13 Dec 2018 23:20:52 +0000 (15:20 -0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 14 Dec 2018 01:59:44 +0000 (20:59 -0500)
commitea5751ccd665a2fd1b24f9af81f6167f0718c5f6
tree1cc50a3dbdf449f104a3cb4295ed84193607180c
parent0afa99648350dbd6d08ee3efd2376db240a6c458
proc/sysctl: don't return ENOMEM on lookup when a table is unregistering

proc_sys_lookup can fail with ENOMEM instead of ENOENT when the
corresponding sysctl table is being unregistered. In our case we see
this upon opening /proc/sys/net/*/conf files while network interfaces
are being deleted, which confuses our configuration daemon.

The problem was successfully reproduced and this fix tested on v4.9.122
and v4.20-rc6.

v2: return ERR_PTRs in all cases when proc_sys_make_inode fails instead
of mixing them with NULL. Thanks Al Viro for the feedback.

Fixes: ace0c791e6c3 ("proc/sysctl: Don't grab i_lock under sysctl_lock.")
Cc: stable@vger.kernel.org
Signed-off-by: Ivan Delalande <colona@arista.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/proc/proc_sysctl.c