io_uring: fix not locked access to fixed buf table
authorPavel Begunkov <asml.silence@gmail.com>
Thu, 9 Jun 2022 07:34:35 +0000 (08:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 Jul 2022 14:41:18 +0000 (16:41 +0200)
commitea512d540a55a75058ee4b78abfd1d499b229d1d
treef91bb3ca9ceaae0efa7ce2ec0c25f8466aa6605c
parent5696f7983d5d0dc070b4c0c07969d528aa553827
io_uring: fix not locked access to fixed buf table

commit 05b538c1765f8d14a71ccf5f85258dcbeaf189f7 upstream.

We can look inside the fixed buffer table only while holding
->uring_lock, however in some cases we don't do the right async prep for
IORING_OP_{WRITE,READ}_FIXED ending up with NULL req->imu forcing making
an io-wq worker to try to resolve the fixed buffer without proper
locking.

Move req->imu setup into early req init paths, i.e. io_prep_rw(), which
is called unconditionally for rw requests and under uring_lock.

Fixes: 634d00df5e1cf ("io_uring: add full-fledged dynamic buffers support")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/io_uring.c