lib/string_helpers: Consolidate string helpers implementation
authorLucas De Marchi <lucas.demarchi@intel.com>
Wed, 26 Jan 2022 09:39:41 +0000 (01:39 -0800)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 7 Feb 2022 21:03:07 +0000 (13:03 -0800)
commitea4692c75e1c63926e4fb0728f5775ef0d733888
tree59fa8aedd9b1e70cdcf5c25a2197ace105a43ab8
parent542898c5aa5c6a3179dffb1d1606884a63f75fed
lib/string_helpers: Consolidate string helpers implementation

There are a few implementations of string helpers in the tree like yesno()
that just returns "yes" or "no" depending on a boolean argument. Those
are helpful to output strings to the user or log.

In order to consolidate them, prefix all of them str_ prefix to make it
clear what they are about and avoid symbol clashes.
Taking the commoon `val ? "yes" : "no"` implementation,  quite a few
users of open coded yesno() could later be converted to the new
function:

$ git grep '?\s*"yes"\s*' | wc -l
286
$ git grep '?\s*"no"\s*' | wc -l
20

The inlined function should keep the const strings local to each
compilation unit, the same way it's now, thus not changing the current
behavior.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220126093951.1470898-2-lucas.demarchi@intel.com
include/linux/string_helpers.h