Cleanup corelib autotests.
authorJason McDonald <jason.mcdonald@nokia.com>
Thu, 22 Dec 2011 07:16:48 +0000 (17:16 +1000)
committerQt by Nokia <qt-info@nokia.com>
Wed, 28 Dec 2011 03:48:11 +0000 (04:48 +0100)
commitea415e20607016651f3cef02dff109235d84eb4d
tree8c954afe7d078b0ca742a1f2249ccc5a9ddf1b82
parent1e7296f3f2e7346f52e8f70d4e531405a248aa8b
Cleanup corelib autotests.

When using QSignalSpy, always verify that the signal spy is valid.  This
will cause the test to give a meaningful failure when spying on a
non-existant signal.  Without this change, tests that spy on a signal to
ensure that it is not emitted (i.e. by comparing the spy count to zero)
could pass erroneously if something went wrong when creating the signal
spy, as an invalid QSignalSpy will always return a count of zero.

Change-Id: I41f4a63d9f0de9190a86de237662dc96be802446
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
19 files changed:
tests/auto/corelib/animation/qanimationgroup/tst_qanimationgroup.cpp
tests/auto/corelib/animation/qparallelanimationgroup/tst_qparallelanimationgroup.cpp
tests/auto/corelib/animation/qpropertyanimation/tst_qpropertyanimation.cpp
tests/auto/corelib/animation/qsequentialanimationgroup/tst_qsequentialanimationgroup.cpp
tests/auto/corelib/concurrent/qfuturewatcher/tst_qfuturewatcher.cpp
tests/auto/corelib/io/qfile/tst_qfile.cpp
tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp
tests/auto/corelib/io/qprocess/tst_qprocess.cpp
tests/auto/corelib/itemmodels/qabstractitemmodel/tst_qabstractitemmodel.cpp
tests/auto/corelib/itemmodels/qidentityproxymodel/tst_qidentityproxymodel.cpp
tests/auto/corelib/itemmodels/qitemselectionmodel/tst_qitemselectionmodel.cpp
tests/auto/corelib/itemmodels/qsortfilterproxymodel/tst_qsortfilterproxymodel.cpp
tests/auto/corelib/kernel/qeventloop/tst_qeventloop.cpp
tests/auto/corelib/kernel/qitemmodel/tst_qitemmodel.cpp
tests/auto/corelib/kernel/qmetaobject/tst_qmetaobject.cpp
tests/auto/corelib/kernel/qsocketnotifier/tst_qsocketnotifier.cpp
tests/auto/corelib/plugin/qpluginloader/tst_qpluginloader.cpp
tests/auto/corelib/statemachine/qstatemachine/tst_qstatemachine.cpp
tests/auto/corelib/tools/qtimeline/tst_qtimeline.cpp