cifs: Fix the error length of VALIDATE_NEGOTIATE_INFO message
authorZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Mon, 26 Sep 2022 03:36:29 +0000 (11:36 +0800)
committerSteve French <stfrench@microsoft.com>
Wed, 5 Oct 2022 06:28:55 +0000 (01:28 -0500)
commite98ecc6e94f4e6d21c06660b0f336df02836694f
tree9d3bb58c7b99ed4a6c0b9eacc26efbcc9f362071
parentbb44c31cdcac107344dd2fcc3bd0504a53575c51
cifs: Fix the error length of VALIDATE_NEGOTIATE_INFO message

Commit d5c7076b772a ("smb3: add smb3.1.1 to default dialect list")
extend the dialects from 3 to 4, but forget to decrease the extended
length when specific the dialect, then the message length is larger
than expected.

This maybe leak some info through network because not initialize the
message body.

After apply this patch, the VALIDATE_NEGOTIATE_INFO message length is
reduced from 28 bytes to 26 bytes.

Fixes: d5c7076b772a ("smb3: add smb3.1.1 to default dialect list")
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: <stable@vger.kernel.org>
Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: Tom Talpey <tom@talpey.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2pdu.c