NFS: Sync the correct byte range during synchronous writes
authortarangg@amazon.com <tarangg@amazon.com>
Thu, 7 Sep 2017 13:29:23 +0000 (09:29 -0400)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Thu, 7 Sep 2017 15:07:13 +0000 (11:07 -0400)
commite973b1a5999e57da677ab50da5f5479fdc0f0c31
treee6c6e1e64fd7149e6ba99f45ca01ee0e80e4847c
parent58a69893a9bf6833a79dae801da78e1d4f46f0a2
NFS: Sync the correct byte range during synchronous writes

Since commit 18290650b1c8 ("NFS: Move buffered I/O locking into
nfs_file_write()") nfs_file_write() has not flushed the correct byte
range during synchronous writes.  generic_write_sync() expects that
iocb->ki_pos points to the right edge of the range rather than the
left edge.

To replicate the problem, open a file with O_DSYNC, have the client
write at increasing offsets, and then print the successful offsets.
Block port 2049 partway through that sequence, and observe that the
client application indicates successful writes in advance of what the
server received.

Fixes: 18290650b1c8 ("NFS: Move buffered I/O locking into nfs_file_write()")
Signed-off-by: Jacob Strauss <jsstraus@amazon.com>
Signed-off-by: Tarang Gupta <tarangg@amazon.com>
Tested-by: Tarang Gupta <tarangg@amazon.com>
Cc: stable@vger.kernel.org # v4.8+
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
fs/nfs/file.c