macvtap: check minor when unregistering
authorFrancesco Ruggeri <fruggeri@arista.com>
Sat, 23 Apr 2016 22:04:31 +0000 (15:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Apr 2016 19:17:45 +0000 (15:17 -0400)
commite96c37f185529d1db4ebc021e4f56822d43945bb
treef2f4f5f2c66a81ba4505b8dc309ca7c30fe10d1b
parent308379607548524b8d86dbf20134681024935e0b
macvtap: check minor when unregistering

macvtap_device_event(NETDEV_UNREGISTER) should check vlan->minor to
determine if it is being invoked in the context of a macvtap_newlink
that failed, for example in this code sequence:

macvtap_newlink
  macvlan_common_newlink
    register_netdevice
      call_netdevice_notifiers(NETDEV_REGISTER, dev)
        macvtap_device_event(NETDEV_REGISTER)
          <fail here, vlan->minor = 0>
      rollback_registered(dev);
        rollback_registered_many
          call_netdevice_notifiers(NETDEV_UNREGISTER, dev);
            macvtap_device_event(NETDEV_UNREGISTER)
              <nothing to clean up here>

Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvtap.c