platform/surface: aggregator_cdev: Add comments regarding unchecked allocation size
authorMaximilian Luz <luzmaximilian@gmail.com>
Mon, 11 Jan 2021 15:48:51 +0000 (16:48 +0100)
committerHans de Goede <hdegoede@redhat.com>
Wed, 13 Jan 2021 09:30:21 +0000 (10:30 +0100)
commite94a26504f41b2ad33ea1473d32506b01bf6693a
treee371e98e6b994e33c6e39d798b4f3622243ea058
parenta403c1dfcf9fb73a4a362f14ca1c1f04662c49e0
platform/surface: aggregator_cdev: Add comments regarding unchecked allocation size

CI static analysis complains about the allocation size in payload and
response buffers being unchecked. In general, these allocations should
be safe as the user-input is u16 and thus limited to U16_MAX, which is
only slightly larger than the theoretical maximum imposed by the
underlying SSH protocol.

All bounds on these values required by the underlying protocol are
enforced in ssam_request_sync() (or rather the functions called by it),
thus bounds here are only relevant for allocation.

Add comments explaining that this should be safe.

Reported-by: Colin Ian King <colin.king@canonical.com>
Fixes: 178f6ab77e61 ("platform/surface: Add Surface Aggregator user-space interface")
Addresses-Coverity: ("Untrusted allocation size")
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210111154851.325404-3-luzmaximilian@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/surface_aggregator_cdev.c