Fix `script -lpython` to handle control flow in one-line commands.
authorDave Lee <davelee.com@gmail.com>
Thu, 16 Jun 2022 05:08:21 +0000 (22:08 -0700)
committerDave Lee <davelee.com@gmail.com>
Thu, 16 Jun 2022 05:20:48 +0000 (22:20 -0700)
commite9349ef9e6d83aa8900b5e534f1d15fb4d44a33c
tree80b670230970720fd3c87de45d8c47cfcd146971
parente30c493894c410825ad7467f4996aca7f613ce81
Fix `script -lpython` to handle control flow in one-line commands.

The fix is to append a newline to the source being evaluated.

Without this patch, the following commands **print no output, no errors**.

```
(lldb) script if "foo" in lldb.frame.name: print(lldb.thread)
(lldb) script for f in lldb.thread: print(f.name)
```

The issue is with `code.InteractiveConsole.runsource()`. A trailing newline is
needed for these expressions to be evaluated. I don't know why this is, the
docs don't mention anything.

From a python repl, the following samples show that a terminal newline allows
statements containing flow control to fully execute.

```
>>> import code
>>> repl = code.InteractiveConsole()
>>> repl.runsource("if True: print(1)")
True
>>> repl.runsource("if True: print(1)\n")
1
False
```

Notes:

From an interactive python repl, the output is not printed immediately. The
user is required to enter a blank line following the first.

```
>>> if True: print(1)
...
1
```

However, `python -c 'if True: print(1)'` works without needing a newline.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D127586
lldb/source/Interpreter/embedded_interpreter.py
lldb/test/Shell/ScriptInterpreter/Python/python.test