dm9601: fix phy/eeprom write routine
authorPeter Korsgaard <jacmet@sunsite.dk>
Mon, 3 May 2010 10:01:26 +0000 (10:01 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 May 2010 22:26:30 +0000 (15:26 -0700)
commite9162ab1610531d6ea6c1833daeb2613e44275e8
tree344f7b49cbf7cbe3b61de4f18362d286226b4d4c
parent19937d0482cfe194fe52e97e59aa58ec911de0d1
dm9601: fix phy/eeprom write routine

Use correct bit positions in DM_SHARED_CTRL register for writes.

Michael Planes recently encountered a 'KY-RS9600 USB-LAN converter', which
came with a driver CD containing a Linux driver. This driver turns out to
be a copy of dm9601.c with symbols renamed and my copyright stripped.
That aside, it did contain 1 functional change in dm_write_shared_word(),
and after checking the datasheet the original value was indeed wrong
(read versus write bits).

On Michaels HW, this change bumps receive speed from ~30KB/s to ~900KB/s.
On other devices the difference is less spectacular, but still significant
(~30%).

Reported-by: Michael Planes <michael.planes@free.fr>
CC: stable@kernel.org
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/dm9601.c