regulator: qcom_smd: Fix pm8916_pldo range
authorStephan Gerhold <stephan.gerhold@kernkonzept.com>
Thu, 23 Jun 2022 09:46:12 +0000 (11:46 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 29 Jun 2022 15:32:08 +0000 (16:32 +0100)
commite8977917e116d1571dacb8e9864474551c1c12bd
treeb37bf1ba024a5989be0eebcb08f1b5571112e4c1
parent122e951eb8045338089b086c8bd9b0b9afb04a92
regulator: qcom_smd: Fix pm8916_pldo range

The PM8916 device specification [1] documents a programmable range of
1.75V to 3.337V with 12.5mV steps for the PMOS LDOs in PM8916. This
range is also used when controlling the regulator directly using the
qcom_spmi-regulator driver ("ult_pldo" there).

However, for some reason the qcom_smd-regulator driver allows a much
larger range for the same hardware component. This could be simply a
typo, since the start of the range is essentially just missing a '1'.

In practice this does not cause any major problems, since the driver
just sends the actual voltage to the RPM firmware instead of making use
of the incorrect voltage selector. Still, having the wrong range there
is confusing and prevents the regulator core from validating requests
correctly.

[1]: https://developer.qualcomm.com/download/sd410/pm8916pm8916-1-power-management-ic-device-specification.pdf

Fixes: 57d6567680ed ("regulator: qcom-smd: Add PM8916 support")
Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
Link: https://lore.kernel.org/r/20220623094614.1410180-2-stephan.gerhold@kernkonzept.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/qcom_smd-regulator.c