dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 7 May 2018 01:40:34 +0000 (01:40 +0000)
committerVinod Koul <vkoul@kernel.org>
Mon, 7 May 2018 08:01:32 +0000 (13:31 +0530)
commite891e41ee301a57fc74a4a0d4da60fdc9669e50c
treee783ee2f7cd1c5a4617e339c195813da3ecb1595
parentab42ddb9eb71b580349b03e4fc5bfcf230422eb8
dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe()

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);

Fixes: 9b3b8171f7f4 ("dmaengine: sprd: Add Spreadtrum DMA driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sprd-dma.c