RDMA/cma: Fix incorrect Packet Lifetime calculation
authorHåkon Bugge <haakon.bugge@oracle.com>
Tue, 22 Jun 2021 14:13:27 +0000 (16:13 +0200)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 25 Jun 2021 13:54:34 +0000 (10:54 -0300)
commite84045eab69c625bc0b0bf24d8e05bc65da1eed1
treed62909844be0f9a4dd830dc718d83a3ef12ae7bf
parentca0c448d2b9f43e3175835d536853854ef544e22
RDMA/cma: Fix incorrect Packet Lifetime calculation

An approximation for the PacketLifeTime is half the local ACK timeout.
The encoding for both timers are logarithmic.

If the local ACK timeout is set, but zero, it means the timer is
disabled. In this case, we choose the CMA_IBOE_PACKET_LIFETIME value,
since 50% of infinite makes no sense.

Before this commit, the PacketLifeTime became 255 if local ACK
timeout was zero (not running).

Fixed by explicitly testing for timeout being zero.

Fixes: e1ee1e62bec4 ("RDMA/cma: Use ACK timeout for RoCE packetLifeTime")
Link: https://lore.kernel.org/r/1624371207-26710-1-git-send-email-haakon.bugge@oracle.com
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/core/cma.c