sfc: ensure type is valid before updating seen_gen
authorEdward Cree <ecree.xilinx@gmail.com>
Mon, 21 Nov 2022 21:37:08 +0000 (21:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 23 Nov 2022 13:47:51 +0000 (13:47 +0000)
commite80bd08fd75a644e2337fb535c1afdb6417357ff
tree72ed9cb84c184f0cbf2269221d93477b436c3f27
parent9f225444467b98579cf28d94f4ad053460dfdb84
sfc: ensure type is valid before updating seen_gen

In the case of invalid or corrupted v2 counter update packets,
 efx_tc_rx_version_2() returns EFX_TC_COUNTER_TYPE_MAX.  In this case
 we should not attempt to update generation counts as this will write
 beyond the end of the seen_gen array.

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527356 ("Memory - illegal accesses")
Fixes: 25730d8be5d8 ("sfc: add extra RX channel to receive MAE counter updates on ef100")
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/tc_counters.c