media: vcodec: Fix potential array out-of-bounds in encoder queue_setup
authorWei Chen <harperchen1110@gmail.com>
Thu, 10 Aug 2023 08:23:33 +0000 (08:23 +0000)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 23 Aug 2023 07:56:08 +0000 (09:56 +0200)
commite7f2e65699e2290fd547ec12a17008764e5d9620
tree5e9d6d7739ba49296e0267cd5b66e1483e070555
parent2908042a37b56d6a9a595eca946e187e9d2df39a
media: vcodec: Fix potential array out-of-bounds in encoder queue_setup

variable *nplanes is provided by user via system call argument. The
possible value of q_data->fmt->num_planes is 1-3, while the value
of *nplanes can be 1-8. The array access by index i can cause array
out-of-bounds.

Fix this bug by checking *nplanes against the array size.

Fixes: 4e855a6efa54 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c