vdpa: validate provisioned device features against specified attribute
authorSi-Wei Liu <si-wei.liu@oracle.com>
Mon, 6 Feb 2023 23:12:01 +0000 (15:12 -0800)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 21 Feb 2023 00:27:00 +0000 (19:27 -0500)
commite7d09cd1d4a2a83e91a2d2b1713621a8042dd73c
tree0727b86f67052bee595da0e775dca33760feaa3c
parent6e6d39830bc681533d97af78e2066a7e9ab6b5d8
vdpa: validate provisioned device features against specified attribute

With device feature provisioning, there's a chance for misconfiguration
that the vdpa feature attribute supplied in 'vdpa dev add' command doesn't
get selected on the device_features to be provisioned. For instance, when
a @mac attribute is specified, the corresponding feature bit _F_MAC in
device_features should be set for consistency. If there's conflict on
provisioned features against the attribute, it should be treated as an
error to fail the ambiguous command. Noted the opposite is not
necessarily true, for e.g. it's okay to have _F_MAC set in device_features
without providing a corresponding @mac attribute, in which case the vdpa
vendor driver could load certain default value for attribute that is not
explicitly specified.

Generalize this check in vdpa core so that there's no duplicate code in
each vendor driver.

Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
Reviewed-by: Eli Cohen <elic@nvidia.com>
Message-Id: <1675725124-7375-4-git-send-email-si-wei.liu@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vdpa/vdpa.c