printk: ringbuffer: avoid memcpy() on state_var
authorJohn Ogness <john.ogness@linutronix.de>
Mon, 14 Sep 2020 09:48:03 +0000 (11:54 +0206)
committerPetr Mladek <pmladek@suse.com>
Tue, 15 Sep 2020 12:42:09 +0000 (14:42 +0200)
commite7c1fe21046a024a5a9ef46e3752521afc1ada7b
treeb175c311c3fde2b4b5b33095e03c0c42ef8a4fac
parentce003d67ad521d950687bce7e42e5361022c7d3d
printk: ringbuffer: avoid memcpy() on state_var

@state_var is copied as part of the descriptor copying via
memcpy(). This is not allowed because @state_var is an atomic type,
which in some implementations may contain a spinlock.

Avoid using memcpy() with @state_var by explicitly copying the other
fields of the descriptor. @state_var is set using atomic set
operator before returning.

Fixes: b6cf8b3f3312 ("printk: add lockless ringbuffer")
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20200914094803.27365-2-john.ogness@linutronix.de
kernel/printk/printk_ringbuffer.c