ovl: warn instead of error if d_type is not supported
authorVivek Goyal <vgoyal@redhat.com>
Fri, 1 Jul 2016 14:02:44 +0000 (10:02 -0400)
committerMiklos Szeredi <mszeredi@redhat.com>
Sun, 3 Jul 2016 07:39:31 +0000 (09:39 +0200)
commite7c0b5991dd1be7b6f6dc2b54a15a0f47b64b007
treee980523614efa528bce39c26a1ceacc90cd3e0b9
parent03bea60409328de54e4ff7ec41672e12a9cb0908
ovl: warn instead of error if d_type is not supported

overlay needs underlying fs to support d_type. Recently I put in a
patch in to detect this condition and started failing mount if
underlying fs did not support d_type.

But this breaks existing configurations over kernel upgrade. Those who
are running docker (partially broken configuration) with xfs not
supporting d_type, are surprised that after kernel upgrade docker does
not run anymore.

https://github.com/docker/docker/issues/22937#issuecomment-229881315

So instead of erroring out, detect broken configuration and warn
about it. This should allow existing docker setups to continue
working after kernel upgrade.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 45aebeaf4f67 ("ovl: Ensure upper filesystem supports d_type")
Cc: <stable@vger.kernel.org> 4.6
fs/overlayfs/super.c