remove FILE* bindings from SBInstruction.
authorLawrence D'Anna <lawrence_danna@apple.com>
Mon, 14 Oct 2019 20:59:57 +0000 (20:59 +0000)
committerLawrence D'Anna <lawrence_danna@apple.com>
Mon, 14 Oct 2019 20:59:57 +0000 (20:59 +0000)
commite7a9115680e22fac3dc996800deaec773becfac0
treee9841c7d98ae49243139ad4be606fdc9def75e6d
parentd88c7dec2187a68109f3c020cc86685e7b2183d5
remove FILE* bindings from SBInstruction.

Summary:
This patch replaces the FILE* python bindings for SBInstruction and
SBInstructionList and replaces them with the new, safe SBFile and FileSP
bindings.

I also re-enable `Test_Disassemble_VST1_64`, because now we can use
the file bindings as an additional test of the disassembler, and we
can use the disassembler test as a test of the file bindings.

The bugs referred to in the comments appear to have been fixed.   The
radar is closed now and the bugzilla bug does not reproduce with the
instructions given.

Reviewers: JDevlieghere, jasonmolenda, labath

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68890

llvm-svn: 374820
lldb/include/lldb/API/SBInstruction.h
lldb/include/lldb/API/SBInstructionList.h
lldb/packages/Python/lldbsuite/test/python_api/default-constructor/sb_instruction.py
lldb/packages/Python/lldbsuite/test/python_api/default-constructor/sb_instructionlist.py
lldb/packages/Python/lldbsuite/test/python_api/disassemble-raw-data/TestDisassemble_VST1_64.py
lldb/scripts/interface/SBInstruction.i
lldb/scripts/interface/SBInstructionList.i
lldb/source/API/SBInstruction.cpp
lldb/source/API/SBInstructionList.cpp