hugetlbfs: fix a truncation issue in hugepages parameter
authorLiu Yuntao <liuyuntao10@huawei.com>
Sat, 26 Feb 2022 03:11:02 +0000 (19:11 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 26 Feb 2022 17:51:17 +0000 (09:51 -0800)
commite79ce9832316e09529b212a21278d68240ccbf1f
tree6636ff389bbec8db1d3655f029febabe8893ee9a
parent70effdc3756c924f4a2b6af1ec4e2e92e18e1b45
hugetlbfs: fix a truncation issue in hugepages parameter

When we specify a large number for node in hugepages parameter, it may
be parsed to another number due to truncation in this statement:

node = tmp;

For example, add following parameter in command line:

hugepagesz=1G hugepages=4294967297:5

and kernel will allocate 5 hugepages for node 1 instead of ignoring it.

I move the validation check earlier to fix this issue, and slightly
simplifies the condition here.

Link: https://lkml.kernel.org/r/20220209134018.8242-1-liuyuntao10@huawei.com
Fixes: b5389086ad7be0 ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")
Signed-off-by: Liu Yuntao <liuyuntao10@huawei.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/hugetlb.c