ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 4 Feb 2022 17:31:02 +0000 (18:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Feb 2022 11:56:26 +0000 (12:56 +0100)
commite799974e7cbb2e77ec12431512e155574c6ed333
treed4a0bb33b224c3476b4f7fd2269627bf0149891f
parentab142ea5d50270f0a4bdb1c7eb4b947bc3ca972b
ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE

[ Upstream commit dc0075ba7f387fe4c48a8c674b11ab6f374a6acc ]

Commit 4a9af6cac050 ("ACPI: EC: Rework flushing of EC work while
suspended to idle") made acpi_ec_dispatch_gpe() check
pm_wakeup_pending(), but that is before canceling the SCI wakeup,
so pm_wakeup_pending() is always true.  This causes the loop in
acpi_ec_dispatch_gpe() to always terminate after one iteration which
may not be correct.

Address this issue by canceling the SCI wakeup earlier, from
acpi_ec_dispatch_gpe() itself.

Fixes: 4a9af6cac050 ("ACPI: EC: Rework flushing of EC work while suspended to idle")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/ec.c
drivers/acpi/sleep.c