umh: simplify the capability pointer logic
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 2 Mar 2023 23:49:44 +0000 (15:49 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 4 Mar 2023 00:18:19 +0000 (16:18 -0800)
commite778361555713826481be6234fd1aa030bdb035e
treed9d3324983b1c843514559482b0d1776190218b5
parentfb35342f0a6875e52ad2903b215525b24e2f19b3
umh: simplify the capability pointer logic

The usermodehelper code uses two fake pointers for the two capability
cases: CAP_BSET for reading and writing 'usermodehelper_bset', and
CAP_PI to read and write 'usermodehelper_inheritable'.

This seems to be a completely unnecessary indirection, since we could
instead just use the pointers themselves, and never have to do any "if
this then that" kind of logic.

So just get rid of the fake pointer values, and use the real pointer
values instead.

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Kees Cook <keescook@chromium.org>
Cc: Iurii Zaikin <yzaikin@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/umh.c