atm: iphase: fix possible use-after-free in ia_module_exit()
authorZou Wei <zou_wei@huawei.com>
Tue, 11 May 2021 06:53:36 +0000 (14:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:44:38 +0000 (09:44 +0200)
commite759ff76ebbbfcdcf83b6634c54dc47828573d8b
treeb2de05147b71413512688eda58b8696f7d2acf2f
parent2292d9691ce90feac6ca04bcbfd71c7ecce24f2b
atm: iphase: fix possible use-after-free in ia_module_exit()

[ Upstream commit 1c72e6ab66b9598cac741ed397438a52065a8f1f ]

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/atm/iphase.c