Diagnose extensions in 'offsetof'
authorAaron Ballman <aaron@aaronballman.com>
Wed, 18 Jan 2023 13:49:45 +0000 (08:49 -0500)
committerAaron Ballman <aaron@aaronballman.com>
Wed, 18 Jan 2023 13:51:21 +0000 (08:51 -0500)
commite7300e75b51a7e7d4e81975b4be7a6c65f9a8286
treede4e2e3f1ceaca35ae0e37c4417c66b97d9af7d6
parent63ba34f3fb752e0a60a78c21ee694e1064a870ab
Diagnose extensions in 'offsetof'

https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2350.htm made very
clear that it is an UB having type definitions with in offsetof.
Clang supports defining a type as the first argument as a conforming
extension due to how many projects use the construct in C99 and earlier
to calculate the alignment of a type. GCC also supports defining a type
as the first argument.

This adds extension warnings and documentation for the functionality
Clang explicitly supports.

Fixes #57065
Reverts the revert of 39da55e8f548a11f7dadefa73ea73d809a5f1729

Co-authored-by: Yingchi Long <i@lyc.dev>
Co-authored-by: Aaron Ballman <aaron@aaronballman.com>
Differential Revision: https://reviews.llvm.org/D133574
21 files changed:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticParseKinds.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Parse/Parser.h
clang/include/clang/Parse/RAIIObjectsForParser.h
clang/include/clang/Sema/Sema.h
clang/lib/Parse/ParseDecl.cpp
clang/lib/Parse/ParseDeclCXX.cpp
clang/lib/Parse/ParseExpr.cpp
clang/lib/Sema/SemaDecl.cpp
clang/lib/Sema/SemaDeclCXX.cpp
clang/lib/Sema/SemaTemplate.cpp
clang/test/C/C2x/n2350.c [new file with mode: 0644]
clang/test/C/drs/dr4xx.c
clang/test/CXX/drs/dr4xx.cpp
clang/test/CodeGen/offsetof.c
clang/test/Parser/declarators.c
clang/test/Sema/offsetof.c
clang/test/SemaCXX/offsetof.cpp