bpf: selftest: Ensure the return value of bpf_skc_to helpers must be checked
authorMartin KaFai Lau <kafai@fb.com>
Mon, 19 Oct 2020 19:42:19 +0000 (12:42 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 19 Oct 2020 22:57:42 +0000 (15:57 -0700)
commite710bcc6d92c47bb7d8e803b41ef529c09ad6a9e
treec83dcb9413a9726858cbe2fe501bf2ed604ce858
parent93c230e3f5bd6e1d2b2759d582fdfe9c2731473b
bpf: selftest: Ensure the return value of bpf_skc_to helpers must be checked

This patch tests:

int bpf_cls(struct __sk_buff *skb)
{
/* REG_6: sk
 * REG_7: tp
 * REG_8: req_sk
 */

sk = skb->sk;
if (!sk)
return 0;

tp = bpf_skc_to_tcp_sock(sk);
req_sk = bpf_skc_to_tcp_request_sock(sk);
if (!req_sk)
return 0;

/* !tp has not been tested, so verifier should reject. */
return *(__u8 *)tp;
}

Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20201019194219.1051314-1-kafai@fb.com
tools/testing/selftests/bpf/verifier/sock.c