tracing: Kill the unbalanced tr->ref++ in tracing_buffers_open()
authorOleg Nesterov <oleg@redhat.com>
Fri, 19 Jul 2013 15:36:44 +0000 (17:36 +0200)
committerSteven Rostedt <rostedt@goodmis.org>
Fri, 19 Jul 2013 18:32:22 +0000 (14:32 -0400)
commite70e78e3c83b536730e31231dd9b979768d8df3c
treed7aedcba5c94bdcaaf0e08b945e7a7639e2c283c
parenta644a7e9587802eabb2e229177606f6a74a60fc1
tracing: Kill the unbalanced tr->ref++ in tracing_buffers_open()

tracing_buffers_open() does trace_array_get() and then it wrongly
inrcements tr->ref again under trace_types_lock. This means that
every caller leaks trace_array:

# cd /sys/kernel/debug/tracing/
# mkdir instances/X
# true < instances/X/per_cpu/cpu0/trace_pipe_raw
# rmdir instances/X
rmdir: failed to remove `instances/X': Device or resource busy

Link: http://lkml.kernel.org/r/20130719153644.GA18899@redhat.com
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: stable@vger.kernel.org # 3.10
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c