abg-comparison: prefer .empty() over implicit bool conversion of .size()
authorMatthias Maennich <maennich@google.com>
Wed, 29 Jan 2020 15:31:26 +0000 (15:31 +0000)
committerMatthias Maennich <maennich@google.com>
Mon, 3 Feb 2020 14:39:39 +0000 (14:39 +0000)
commite6b9e61ec589ec4c678a6ff9e3ce546a7d8af51b
treee5c61582fae916fc445d396eae9dd297af242d60
parente0088cff7629e17de7948af3f6761220762b42af
abg-comparison: prefer .empty() over implicit bool conversion of .size()

size() is not guaranteed to be a constant-time function. Also, using
.empty() shows clearer intent. Hence switch to using .empty().
That issue was flagged by clang-tidy[1].

* src/abg-comparison.cc (corpus_diff::has_changes): prefer
!container.empty() over bool(container.size())

[1] https://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Reviewed-by: Dodji Seketeli <dodji@seketeli.org>
Signed-off-by: Matthias Maennich <maennich@google.com>
src/abg-comparison.cc