Remove -lower-global-dtors-via-cxa-atexit flag
authorJulian Lettner <julian.lettner@apple.com>
Thu, 9 Mar 2023 19:32:17 +0000 (11:32 -0800)
committerJulian Lettner <julian.lettner@apple.com>
Tue, 14 Mar 2023 21:18:11 +0000 (14:18 -0700)
commite6a789ef9bb28222c91816a2cf00cfd6f706efd4
treea01b2b0b3d37ad7693bb3d3124926ce454a9b720
parente48ae0dbd80d58ce8eded9e55f0b1262d52517af
Remove -lower-global-dtors-via-cxa-atexit flag

Remove the `-lower-global-dtors-via-cxa-atexit` escape hatch introduced
in D121736 [1], which switched the default lowering of global
destructors on MachO to use `__cxa_atexit()` to avoid emitting
deprecated `__mod_term_func` sections.

I added this flag as an escape hatch in case the switch causes any
problems.  We didn't discover any problems so now we can remove it.

[1] https://reviews.llvm.org/D121736

rdar://90277838

Differential Revision: https://reviews.llvm.org/D145715
clang/docs/ReleaseNotes.rst
clang/lib/CodeGen/BackendUtil.cpp
llvm/include/llvm/CodeGen/CommandFlags.h
llvm/include/llvm/Target/TargetOptions.h
llvm/lib/CodeGen/CommandFlags.cpp
llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
llvm/lib/CodeGen/TargetPassConfig.cpp
llvm/test/CodeGen/ARM/ctors_dtors.ll