uaccess: fix integer overflow on access_ok()
authorArnd Bergmann <arnd@arndb.de>
Thu, 10 Feb 2022 15:24:30 +0000 (16:24 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2022 07:58:45 +0000 (09:58 +0200)
commite65d28d4e9bf90a35ba79c06661a572a38391dec
tree6bcaccb91dba8db78710df6afa76856f27b6f968
parent058d62a03e7d057d5eeec0db800117765ff23e6c
uaccess: fix integer overflow on access_ok()

commit 222ca305c9fd39e5ed8104da25c09b2b79a516a8 upstream.

Three architectures check the end of a user access against the
address limit without taking a possible overflow into account.
Passing a negative length or another overflow in here returns
success when it should not.

Use the most common correct implementation here, which optimizes
for a constant 'size' argument, and turns the common case into a
single comparison.

Cc: stable@vger.kernel.org
Fixes: da551281947c ("csky: User access")
Fixes: f663b60f5215 ("microblaze: Fix uaccess_ok macro")
Fixes: 7567746e1c0d ("Hexagon: Add user access functions")
Reported-by: David Laight <David.Laight@aculab.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/csky/include/asm/uaccess.h
arch/hexagon/include/asm/uaccess.h
arch/microblaze/include/asm/uaccess.h