[lldb/DWARF] Don't automatically search dwo unit attributes
authorPavel Labath <pavel@labath.sk>
Sat, 21 Dec 2019 14:29:57 +0000 (15:29 +0100)
committerPavel Labath <pavel@labath.sk>
Fri, 10 Jan 2020 12:29:24 +0000 (13:29 +0100)
commite65282deca8455d1cc6d83b7016af9aa374f9f89
treef2a00ac27aefe675278c1124345b7907d05f1f5d
parent5b7612792aeb5b161fdd69997db2a64b08f075b6
[lldb/DWARF] Don't automatically search dwo unit attributes

This patch removes the code (deep inside DWARFDebugInfoEntry) which
automagically returned the attributes of the dwo unit DIE when asking
for the attributes of the skeleton unit.  This is fairly hacky, and not
consistent with how llvm DWARF parser operates.

Instead, I change the code the explicitly request (via
GetNonSkeletonUnit) the right unit to search (there were just two places
that needed this). If it turns out we need this more often, we can
create a utility function (external to DWARFUnit) for doing this.
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp