Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"
authorSterling Augustine <saugustine@google.com>
Fri, 12 Jun 2020 18:11:20 +0000 (11:11 -0700)
committerSterling Augustine <saugustine@google.com>
Fri, 12 Jun 2020 19:10:13 +0000 (12:10 -0700)
commite64059828f19f629081220bffeb3ef7582870111
tree1d889dba475dd5b9706d79750ab1a69c54e9efcf
parent884fb45ed2aaa053fa76ca8ffa3c9a9ca595bd65
Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

Summary:
This reverts commit 33fb9cbe211d1b43d4b84edf34e11001f04cddf0.

That commit violates layering by adding a dependency from StaticAnalyzer/Core
back to StaticAnalyzer/FrontEnd, creating a circular dependency.

I can't see a clean way to fix it except refactoring.

Reviewers: echristo, Szelethus, martong

Subscribers: xazax.hun, baloghadamsoftware, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, ASDenysPetrov, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81752
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h
clang/lib/StaticAnalyzer/Core/BugReporter.cpp
clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp