usb: gadget: u_serial: Add null pointer check in gserial_suspend
authorPrashanth K <quic_prashk@quicinc.com>
Fri, 5 May 2023 09:18:37 +0000 (14:48 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:52 +0000 (16:21 +0200)
commite60a827ac074ce6bd58305fe5a86afab5fce6a04
tree690b9543b7ae155ed101e39baf3ad0b092bca402
parentc3b322b84ab5dda7eaca9ded763628b7467734f4
usb: gadget: u_serial: Add null pointer check in gserial_suspend

[ Upstream commit 2f6ecb89fe8feb2b60a53325b0eeb9866d88909a ]

Consider a case where gserial_disconnect has already cleared
gser->ioport. And if gserial_suspend gets called afterwards,
it will lead to accessing of gser->ioport and thus causing
null pointer dereference.

Avoid this by adding a null pointer check. Added a static
spinlock to prevent gser->ioport from becoming null after
the newly added null pointer check.

Fixes: aba3a8d01d62 ("usb: gadget: u_serial: add suspend resume callbacks")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Link: https://lore.kernel.org/r/1683278317-11774-1-git-send-email-quic_prashk@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/function/u_serial.c