ALSA: hda/cs35l56: Always power-up and start cs_dsp
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Mon, 31 Jul 2023 16:57:21 +0000 (17:57 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 1 Aug 2023 06:30:06 +0000 (08:30 +0200)
commite5bac77b67082e59f7aceea08a30b5dc66138643
treeb9ac25491784e7d4fc2ae396c5a6a7ee7b8171e1
parent15c378d66fc5bd00ce7c8ac869624f9a4a29d1d4
ALSA: hda/cs35l56: Always power-up and start cs_dsp

Always call cs_dsp_power_up() and cs_dsp_run() in
cs35l56_hda_fw_load() even if there aren't any firmware files
to download. Also, if there aren't any firmware files to
download there is no need to do cs35l56_firmware_shutdown() and
cs35l56_system_reset().

If there aren't any firmware files there's no need to write
anything to the CS35L56 registers to make it work - it will
already be running the ROM firmware. So it's not strictly
necessary to start cs_dsp.

But it's perfectly ok to call cs_dsp_power_up() and
cs_dsp_run() without downloading any firmware. This avoids
having to support a state where audio is playing but cs_dsp
is not running.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230731165726.7940-5-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l56_hda.c