scsi: lpfc: Re-fix use after free in lpfc_rq_buf_free()
authorJames Smart <james.smart@broadcom.com>
Tue, 20 Oct 2020 20:27:13 +0000 (13:27 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 27 Oct 2020 01:42:38 +0000 (21:42 -0400)
commite5785d3ec32f5f44dd88cd7b398e496742630469
tree676222a5acd4e440914bc4840e4d0e7ccbfda8b1
parente7dab164a9aa457f89d4528452bdfc3e15ac98b6
scsi: lpfc: Re-fix use after free in lpfc_rq_buf_free()

Commit 9816ef6ecbc1 ("scsi: lpfc: Use after free in lpfc_rq_buf_free()")
was made to correct a use after free condition in lpfc_rq_buf_free().
Unfortunately, a subsequent patch cut on a tree without the fix
inadvertently reverted the fix.

Put the fix back: Move the freeing of the rqb_entry to after the print
function that references it.

Link: https://lore.kernel.org/r/20201020202719.54726-4-james.smart@broadcom.com
Fixes: 411de511c694 ("scsi: lpfc: Fix RQ empty firmware trap")
Cc: <stable@vger.kernel.org> # v4.17+
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_mem.c