ath11k: fix missing skb drop on htc_tx_completion error
authorChristian 'Ansuel' Marangi <ansuelsmth@gmail.com>
Sat, 28 May 2022 14:25:16 +0000 (16:25 +0200)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 6 Jun 2022 14:07:05 +0000 (17:07 +0300)
commite5646fe3b7ef739c392e59da7db6adf5e1fdef42
treeaa67e23789d6674a423ec794e372e5d5d6811561
parent8723750e2753868591ba86a57b0041c5e38047ad
ath11k: fix missing skb drop on htc_tx_completion error

On htc_tx_completion error the skb is not dropped. This is wrong since
the completion_handler logic expect the skb to be consumed anyway even
when an error is triggered. Not freeing the skb on error is a memory
leak since the skb won't be freed anywere else. Correctly free the
packet on eid >= ATH11K_HTC_EP_COUNT before returning.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

Fixes: f951380a6022 ("ath11k: Disabling credit flow for WMI path")
Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220528142516.20819-2-ansuelsmth@gmail.com
drivers/net/wireless/ath/ath11k/htc.c