drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails
authorMaxime Ripard <maxime@cerno.tech>
Tue, 15 Dec 2020 15:42:38 +0000 (16:42 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 16 Dec 2020 09:11:32 +0000 (10:11 +0100)
commite55a07751146ef8ebc2c561564437b78f46405d3
tree88b03dec5ddc6238406249caa473a3005527992e
parent320e84dc6111ecc1c957e2b186d4d2bafee6bde2
drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails

drm_atomic_helper_connector_reset uses kmalloc which, from an API
standpoint, can fail, and thus setting connector->state to NULL.
However, our reset hook then calls drm_atomic_helper_connector_tv_reset
that will access connector->state without checking if it's a valid
pointer or not.

Make sure we don't end up accessing a NULL pointer.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Suggested-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20201215154243.540115-5-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c