shmem: fix smaps BUG sleeping while atomic
authorHugh Dickins <hughd@google.com>
Wed, 23 Aug 2023 05:14:47 +0000 (22:14 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 24 Aug 2023 21:59:47 +0000 (14:59 -0700)
commite5548f85b4527c4c803b7eae7887c10bf8f90c97
treee89cd6f78cdd98fedad9054d38f517249240016c
parentf84f62e69963d7742acec4340ec1c4c7ef22b887
shmem: fix smaps BUG sleeping while atomic

smaps_pte_hole_lookup() is calling shmem_partial_swap_usage() with page
table lock held: but shmem_partial_swap_usage() does cond_resched_rcu() if
need_resched(): "BUG: sleeping function called from invalid context".

Since shmem_partial_swap_usage() is designed to count across a range, but
smaps_pte_hole_lookup() only calls it for a single page slot, just break
out of the loop on the last or only page, before checking need_resched().

Link: https://lkml.kernel.org/r/6fe3b3ec-abdf-332f-5c23-6a3b3a3b11a9@google.com
Fixes: 230100321518 ("mm/smaps: simplify shmem handling of pte holes")
Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org> [5.16+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/shmem.c