gpio: pca953x: Don't flip bits on PCA957x GPIO expanders when probing them.
authorGraeme Smecher <gsmecher@threespeedlogic.com>
Fri, 13 Sep 2013 21:41:48 +0000 (14:41 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 23 Sep 2013 10:57:11 +0000 (12:57 +0200)
commite5304db8d7541c1338a6313ae951355b5a72cd19
tree0e3fb0e5efe909e605900025d475bdaaeec5a763
parent8fa82b16304b5cdcddb929afbfebfddfb7adb716
gpio: pca953x: Don't flip bits on PCA957x GPIO expanders when probing them.

The pca957x driver supports a handful of I2C GPIO expanders from NXP, Maxim,
and TI. For the PCA9574 and PCA9575 devices only, the driver resets the GPIO
level and direction in the pca957x_probe function. This seems like the wrong
thing to do, since it can cause hardware bit twiddles during warm reboots when
the chip state and reset values don't match.

This kind of initialization is best left upstream (in a bootloader) or
downstream (in userspace). It's also an inconsistency across devices supported
by this driver.

This patch is NOT boot-tested: the SoC I'm  using is stuck on 2.6.37, and the
patch doesn't apply trivially.

Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-pca953x.c