Remove Read/WriteProcessMemory from PAL. (#8655)
authorMike McLaughlin <mikem@microsoft.com>
Sun, 18 Dec 2016 22:48:36 +0000 (14:48 -0800)
committerGitHub <noreply@github.com>
Sun, 18 Dec 2016 22:48:36 +0000 (14:48 -0800)
commite50b22b4f07b452b3ce7261fb543a43aa8f70b88
treea3910ccba568b59c4f60cdda7ac7cd9f8357afc9
parent4497b25d1107846e0ac8d09fa13e40173528fe9e
Remove Read/WriteProcessMemory from PAL. (#8655)

Ifdef more unused code that uses ReadProcessMemory. Move the current
memory probing in the transport to PAL_ProbeMemory. Add PAL_ProbeMemory
to dac PAL exports.

PAL_ProbeMemory may be changed to use write/read on a pipe to
validate the memory as soon as we make it perform as well as
the current code.

Remove ReadProcessMemory tests and add PAL_ProbeMemory pal tests.
27 files changed:
src/debug/daccess/fntableaccess.cpp
src/debug/di/rspriv.inl
src/debug/shared/dbgtransportsession.cpp
src/dlls/mscordac/mscordac_unixexports.src
src/inc/livedatatarget.h
src/jit/ee_il_dll.cpp
src/pal/inc/pal.h
src/pal/src/debug/debug.cpp
src/pal/tests/palsuite/filemapping_memmgt/CMakeLists.txt
src/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/CMakeLists.txt [moved from src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/CMakeLists.txt with 50% similarity]
src/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/ProbeMemory_neg1/CMakeLists.txt [new file with mode: 0644]
src/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/ProbeMemory_neg1/ProbeMemory_neg.cpp [moved from src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/ReadProcessMemory_neg1/ReadProcessMemory_neg.cpp with 54% similarity]
src/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/ProbeMemory_neg1/testinfo.dat [moved from src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test1/testinfo.dat with 59% similarity]
src/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/test1/CMakeLists.txt [new file with mode: 0644]
src/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/test1/ProbeMemory.cpp [moved from src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test1/ReadProcessMemory.cpp with 53% similarity]
src/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/test1/testinfo.dat [moved from src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/ReadProcessMemory_neg1/testinfo.dat with 58% similarity]
src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/ReadProcessMemory_neg1/CMakeLists.txt [deleted file]
src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test1/CMakeLists.txt [deleted file]
src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test2/CMakeLists.txt [deleted file]
src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test2/commonconsts.h [deleted file]
src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test2/helper.cpp [deleted file]
src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test2/test2.cpp [deleted file]
src/pal/tests/palsuite/filemapping_memmgt/ReadProcessMemory/test2/testinfo.dat [deleted file]
src/pal/tests/palsuite/paltestlist.txt
src/pal/tests/palsuite/threading/DuplicateHandle/CMakeLists.txt
src/utilcode/CMakeLists.txt
src/vm/debughelp.cpp