Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()
authorAndrea Parri (Microsoft) <parri.andrea@gmail.com>
Wed, 9 Dec 2020 07:08:26 +0000 (08:08 +0100)
committerWei Liu <wei.liu@kernel.org>
Fri, 5 Feb 2021 09:55:42 +0000 (09:55 +0000)
commite4d221b42354b2e2ddb9187a806afb651eee2cda
treeed8fb74205a96a8ca8c94eaccb1c8e2eec4ac5db
parente3fa4b747f085d2cda09bba0533b86fa76038635
Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

An erroneous or malicious host could send multiple rescind messages for
a same channel.  In vmbus_onoffer_rescind(), the guest maps the channel
ID to obtain a pointer to the channel object and it eventually releases
such object and associated data.  The host could time rescind messages
and lead to an use-after-free.  Add a new flag to the channel structure
to make sure that only one instance of vmbus_onoffer_rescind() can get
the reference to the channel object.

Reported-by: Juan Vazquez <juvazq@microsoft.com>
Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20201209070827.29335-6-parri.andrea@gmail.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/channel_mgmt.c
include/linux/hyperv.h