of: module: prevent NULL pointer dereference in vsnprintf()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Wed, 27 Mar 2024 16:52:49 +0000 (19:52 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:36:06 +0000 (16:36 +0200)
commite4a449368a2ce6d57a775d0ead27fc07f5a86e5b
tree575afaed63ec73f42159635c97062d6c8d2da16c
parent37b81aed6468a031f8515142e226e6ddc392b9a2
of: module: prevent NULL pointer dereference in vsnprintf()

commit a1aa5390cc912934fee76ce80af5f940452fa987 upstream.

In of_modalias(), we can get passed the str and len parameters which would
cause a kernel oops in vsnprintf() since it only allows passing a NULL ptr
when the length is also 0. Also, we need to filter out the negative values
of the len parameter as these will result in a really huge buffer since
snprintf() takes size_t parameter while ours is ssize_t...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/1d211023-3923-685b-20f0-f3f90ea56e1f@omp.ru
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/of/module.c