drm/i915/gt: Do release kernel context if breadcrumb measure fails
authorJanusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Fri, 7 May 2021 14:42:51 +0000 (16:42 +0200)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Mon, 10 May 2021 09:19:43 +0000 (10:19 +0100)
commite49a8b2cc8522a836ec2ade3d8e4dc02de6f4d67
tree19128155262ea38836e5acfa35c063521d8b4680
parentae9faeb9a2c9019953590dcf71312f70ce53c7d0
drm/i915/gt: Do release kernel context if breadcrumb measure fails

Commit fb5970da1b42 ("drm/i915/gt: Use the kernel_context to measure the
breadcrumb size") reordered some operations inside engine_init_common()
and added an error unwind path to that function.  In that path, a
reference to a kernel context candidate supposed to be released on error
was put, but the context, pinned when created, was not unpinned first.
Fix it by replacing intel_context_put() with destroy_pinned_context()
introduced later by commit b436a5f8b6c8 ("drm/i915/gt: Track all timelines
created using the HWSP").

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210507144251.376538-1-janusz.krzysztofik@linux.intel.com
drivers/gpu/drm/i915/gt/intel_engine_cs.c