ACPI: custom_method: fix potential use-after-free issue
authorMark Langsdorf <mlangsdo@redhat.com>
Fri, 23 Apr 2021 15:28:17 +0000 (10:28 -0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 28 Apr 2021 17:15:30 +0000 (19:15 +0200)
commite483bb9a991bdae29a0caa4b3a6d002c968f94aa
tree53ecd99c930bedcfd25fbfc5ef1718c928278a3f
parentd8f9176b4ece17e831306072678cd9ae49688cf5
ACPI: custom_method: fix potential use-after-free issue

In cm_write(), buf is always freed when reaching the end of the
function.  If the requested count is less than table.length, the
allocated buffer will be freed but subsequent calls to cm_write() will
still try to access it.

Remove the unconditional kfree(buf) at the end of the function and
set the buf to NULL in the -EINVAL error path to match the rest of
function.

Fixes: 03d1571d9513 ("ACPI: custom_method: fix memory leaks")
Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
Cc: 5.4+ <stable@vger.kernel.org> # 5.4+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/custom_method.c