ARM: 8806/1: kprobes: Fix false positive with FORTIFY_SOURCE
authorKees Cook <keescook@chromium.org>
Tue, 30 Oct 2018 21:12:56 +0000 (22:12 +0100)
committerRussell King <rmk+kernel@armlinux.org.uk>
Thu, 8 Nov 2018 10:59:10 +0000 (10:59 +0000)
commite46daee53bb50bde38805f1823a182979724c229
tree4fddda4f42739fd0cabfd7acea1a52a620365ada
parent651022382c7f8da46cb4872a545ee1da6d097d2a
ARM: 8806/1: kprobes: Fix false positive with FORTIFY_SOURCE

The arm compiler internally interprets an inline assembly label
as an unsigned long value, not a pointer. As a result, under
CONFIG_FORTIFY_SOURCE, the address of a label has a size of 4 bytes,
which was tripping the runtime checks. Instead, we can just cast the label
(as done with the size calculations earlier).

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1639397

Reported-by: William Cohen <wcohen@redhat.com>
Fixes: 6974f0c4555e ("include/linux/string.h: add the option of fortified string.h functions")
Cc: stable@vger.kernel.org
Acked-by: Laura Abbott <labbott@redhat.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Tested-by: William Cohen <wcohen@redhat.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
arch/arm/probes/kprobes/opt-arm.c