net/mlx5: Fix memory leak in error flow of port set buffer
authorMaher Sanalla <msanalla@nvidia.com>
Tue, 17 Jan 2023 12:54:36 +0000 (14:54 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 8 Feb 2023 00:29:55 +0000 (16:29 -0800)
commite3e01c1c15986f9531b854634eec8381e72cb605
treeca60c34fa66016a622b9da3000b8a96d17a37bd1
parent1e985a8d887cd0b25541ba977db171be47cf575d
net/mlx5: Fix memory leak in error flow of port set buffer

In the cited commit, shared buffer updates were added whenever
port buffer gets updated.

However, in case the shared buffer update fails, exiting early from
port_set_buffer() is performed without freeing previously-allocated memory.

Fix it by jumping to out label where memory is freed before returning
with error.

Fixes: a440030d8946 ("net/mlx5e: Update shared buffer along with device buffer changes")
Signed-off-by: Maher Sanalla <msanalla@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c