Move vgdb special case into remote_filesystem_is_local
authorGary Benson <gbenson@redhat.com>
Fri, 5 Jun 2015 15:08:05 +0000 (16:08 +0100)
committerGary Benson <gbenson@redhat.com>
Fri, 5 Jun 2015 15:08:05 +0000 (16:08 +0100)
commite3dd7556ad89bf00c2a92f76079ae1c53dc130a8
tree79bf7fdb88953c5a9aaefc0cded72b96d94518ad
parentf8b447819b3d65c3bea65dee860110aa198c081e
Move vgdb special case into remote_filesystem_is_local

Valgrind GDB (vgdb) presents itself as a remote target but works on
the local filesystem.  gdb_bfd_open contained a special case to make
vgdb work with "target:" sysroots, but the implementation meant that
GDB would fall back to the local filesystem if *any* to_fileio_open
method failed with ENOSYS for *any* reason.  This commit moves the
vgdb special case to remote_filesystem_is_local to allow the fallback
to be restricted only to the specific case that remote file transfer
is unsupported.  This commit also adds a warning which is displayed
the first time the fallback is used.

gdb/ChangeLog:

* gdb_bfd.c (gdb_bfd_open): Move vgdb special case to...
* remote.c (remote_filesystem_is_local): ...here.
gdb/ChangeLog
gdb/gdb_bfd.c
gdb/remote.c