af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connec...
authorMateusz Jurczyk <mjurczyk@google.com>
Fri, 23 Jun 2017 17:32:28 +0000 (19:32 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 25 Jun 2017 15:42:58 +0000 (11:42 -0400)
commite3c42b61ff813921ba58cfc0019e3fd63f651190
treeee58efff6351bd05c142d03fe1a4e8f1b10afdab
parent2e56c26b391810461170547509649f0c11717f65
af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connect handlers

Verify that the caller-provided sockaddr structure is large enough to
contain the sa_family field, before accessing it in bind() and connect()
handlers of the AF_IUCV socket. Since neither syscall enforces a minimum
size of the corresponding memory region, very short sockaddrs (zero or
one byte long) result in operating on uninitialized memory while
referencing .sa_family.

Fixes: 52a82e23b9f2 ("af_iucv: Validate socket address length in iucv_sock_bind()")
Signed-off-by: Mateusz Jurczyk <mjurczyk@google.com>
[jwi: removed unneeded null-check for addr]
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/iucv/af_iucv.c