can: isotp: isotp_sendmsg(): fix return error fix on TX path
authorOliver Hartkopp <socketcan@hartkopp.net>
Wed, 7 Jun 2023 07:27:08 +0000 (09:27 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 22 Jun 2023 08:45:09 +0000 (10:45 +0200)
commite38910c0072b541a91954682c8b074a93e57c09b
treef05a5da6cdab0752206842f3374cbc2715ebe1b4
parent7f4e09700bdc13ce9aafa279bc999051e9bcda35
can: isotp: isotp_sendmsg(): fix return error fix on TX path

With commit d674a8f123b4 ("can: isotp: isotp_sendmsg(): fix return
error on FC timeout on TX path") the missing correct return value in
the case of a protocol error was introduced.

But the way the error value has been read and sent to the user space
does not follow the common scheme to clear the error after reading
which is provided by the sock_error() function. This leads to an error
report at the following write() attempt although everything should be
working.

Fixes: d674a8f123b4 ("can: isotp: isotp_sendmsg(): fix return error on FC timeout on TX path")
Reported-by: Carsten Schmidt <carsten.schmidt-achim@t-online.de>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Link: https://lore.kernel.org/all/20230607072708.38809-1-socketcan@hartkopp.net
Cc: stable@vger.kernel.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/isotp.c