Add the alloc_size attribute to clang, attempt 2.
authorGeorge Burgess IV <george.burgess.iv@gmail.com>
Thu, 22 Dec 2016 02:50:20 +0000 (02:50 +0000)
committerGeorge Burgess IV <george.burgess.iv@gmail.com>
Thu, 22 Dec 2016 02:50:20 +0000 (02:50 +0000)
commite37633713d93b21533d8699d0b5cf4703e3f4039
tree21320a83b48d93d53645c55f3c1d4c5be76ffc17
parent9ac20a1e1073cf8eb40d8efe42e17bd3b2be4682
Add the alloc_size attribute to clang, attempt 2.

This is a recommit of r290149, which was reverted in r290169 due to msan
failures. msan was failing because we were calling
`isMostDerivedAnUnsizedArray` on an invalid designator, which caused us
to read uninitialized memory. To fix this, the logic of the caller of
said function was simplified, and we now have a `!Invalid` assert in
`isMostDerivedAnUnsizedArray`, so we can catch this particular bug more
easily in the future.

Fingers crossed that this patch sticks this time. :)

Original commit message:

This patch does three things:
- Gives us the alloc_size attribute in clang, which lets us infer the
  number of bytes handed back to us by malloc/realloc/calloc/any user
  functions that act in a similar manner.
- Teaches our constexpr evaluator that evaluating some `const` variables
  is OK sometimes. This is why we have a change in
  test/SemaCXX/constant-expression-cxx11.cpp and other seemingly
  unrelated tests. Richard Smith okay'ed this idea some time ago in
  person.
- Uniques some Blocks in CodeGen, which was reviewed separately at
  D26410. Lack of uniquing only really shows up as a problem when
  combined with our new eagerness in the face of const.

llvm-svn: 290297
16 files changed:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGBlocks.cpp
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CodeGenFunction.h
clang/lib/CodeGen/CodeGenModule.h
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/CodeGen/alloc-size.c [new file with mode: 0644]
clang/test/CodeGenCXX/alloc-size.cpp [new file with mode: 0644]
clang/test/CodeGenCXX/block-in-ctor-dtor.cpp
clang/test/CodeGenCXX/global-init.cpp
clang/test/CodeGenOpenCL/cl20-device-side-enqueue.cl
clang/test/Sema/alloc-size.c [new file with mode: 0644]
clang/test/SemaCXX/constant-expression-cxx11.cpp